USE 449 - Bump TDA to version 4.1#382
Merged
Merged
Conversation
Why these changes are being introduced: There was a latent bug that was not exposed until a "full" run was performed in Dev1. We have not used the `opensearch.create_index()` function in AWS since the migration from pipenv to uv, which is failing. This is because the `config/` directory was not included in the Docker image, and thus that import fails. Going to look into a more robust solution, though this works for now. How this addresses that need: Copies `config/` directory into Docker image. Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-449
ehanson8
approved these changes
Mar 16, 2026
| # Copy source | ||
| # Copy source and config | ||
| COPY tim ./tim | ||
| COPY config ./config |
Contributor
Author
There was a problem hiding this comment.
Thanks! It was a sneaky one. Couldn't figure out why things were "fine" in production.... until realizing we just hadn't hit a code path that required this file yet 😅.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
This PR bumps
timdex-dataset-api(TDA) to version 4.1, which supportsduckdb==1.5.This PR also fixess a latent bug.
Since the migration from
pipenvtouv, we have not performed a "full" run in an AWS context which utilizes the Docker container. It turns out that I forgot to include theconfig/directory in the Docker image, which is an issue when we use theopensearch.create_index()helper function.This commit copies the
config/directory into the Docker image and rectifies that. Exploring more robust solutions as follow-up work, e.g. full paths, for the file to ensure that local testing would have exposed that.How can a reviewer manually see the effects of these changes?
See this successful run of StepFunction in Dev1 to demonstrate:
config/directoryIncludes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review